Skip to content

Add test for bug 75577: issue where RFC3339_EXTENDED could not be used via DateTime::createFromFormat #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2021
Merged

Add test for bug 75577: issue where RFC3339_EXTENDED could not be used via DateTime::createFromFormat #2945

merged 3 commits into from
May 10, 2021

Conversation

mariano
Copy link
Contributor

@mariano mariano commented Nov 27, 2017 •
edited
Loading

Actual fix in: derickr/timelib#29

@mariano
Copy link
Contributor Author

mariano commented Nov 27, 2017

@derickr this is a fix for bug https://bugs.php.net/bug.php?id=75577

@tpunt
Copy link
Contributor

tpunt commented Nov 27, 2017

This PR should be made upstream to derickr/timelib, rather than here.

@salathe
Copy link
Contributor

salathe commented Nov 27, 2017

Also note that parse_date.c is a generated file, be sure to apply the changes to parse_date.re then re-generate the C file.

@mariano mariano mentioned this pull request Nov 27, 2017
Closed
@mariano
Copy link
Contributor Author

mariano commented Nov 27, 2017

@tpunt thanks Thomas. Added PR there: derickr/timelib#29

@salathe Good catch, sorry about that newbie mistake :)

@mariano mariano changed the title Fix bug 75577: issue where RFC3339_EXTENDED could not be used via DateTime::createFromFormat Add test for bug 75577: issue where RFC3339_EXTENDED could not be used via DateTime::createFromFormat Nov 27, 2017
@petk
Copy link
Member

petk commented Feb 14, 2019

Worth noting that the bug https://bugs.php.net/bug.php?id=75577 has been resolved and timelib library has the patch merged in. Should this be closed as resolved then?

@derickr
Copy link
Member

derickr commented Feb 15, 2019

@petk Not quite, I think that this test just need to be merged still.

@krakjoe krakjoe closed this May 10, 2021
@krakjoe krakjoe reopened this May 10, 2021
@krakjoe krakjoe merged commit ff38575 into php:PHP-7.2.0 May 10, 2021
krakjoe added a commit that referenced this pull request May 10, 2021
@krakjoe
Revert "Add test for bug 75577: issue where RFC3339_EXTENDED could no…
47b1a36 
…t be used via DateTime::createFromFormat (#2945)"

This reverts commit ff38575.
@krakjoe krakjoe mentioned this pull request May 10, 2021
Merged
krakjoe added a commit that referenced this pull request May 10, 2021
@krakjoe
Revert "Add test for bug 75577: issue where RFC3339_EXTENDED could no…
fe7cc24 
…t be used via DateTime::createFromFormat (#2945)" (#6965)

This reverts commit ff38575.
@krakjoe
Copy link
Member

krakjoe commented May 10, 2021

There was already a test for this, but someone forgot to close the pr ... closing now, sorry about the noise @remicollet, didn't notice bad target :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mariano @tpunt @salathe @petk @derickr @krakjoe