Remove redundant warning in array_push() and array_unshift()

[timurib]

The array_push and array_unshift functions require at least 2 arguments. Requirement about second argument was relevant until version 5.6, because the code array_push($array) really does not make sense. But with argument unpacking syntax we can use spread operator for array union:

array_push($array, ...$values);
array_unshift($array, ...$values);

If the addition list length is not predefined then we should explicitly check the case when this list is emptiness to avoid the warning message, or prepend the expression with @-operator. Actually the functions work well with single argument, they just do not change it. The warning is completely redundant and explicit checking negates the benefit (code size reducing) gained with the spread operator.

For example, relevant array methods push and unshift in the JavaScript work this way:

"use strict";
var array = [1,2,3]
var values = []
array.push(...values)
array.unshift(...values)
// no error messages, both methods just return 3, array is still [1,2,3]

Adding multiple elements to an array is a very common operation. This patch just will make it a little more convenient.

Unfortunately, it may cause the minor BC break for return value. Currently both functions returns NULL when second argument is not passed. With this patch in this case they will return the length of array passed as first argument. Do I need to create RFC for such a small change?

[php-pulls]

Comment on behalf of cmb at php.net:

Thanks! Applied via f7f4864 (also added a note in UPGRADING and fixed the respective arginfos).

[bolknote]

Very strange. Why did not you use other function instead of these? array_merge for example?

[timurib]

@bolknote, yes, of course, array_merge can be used. But when you don't create a new array, but mutate the original one, the array_push is more straightforward way to do this (imho).

Anyway, this commit don't change the actual behavior - the array_push already worked in this manner, it's just removes the warning message for this case.

[bolknote]

@timurib

this commit don't change the actual behavior

Of course I got it. :) But I still think that you can do it without this change.

[nikic]

Speaking of array_merge, we should also allow zero arguments there as well. I've seen people write array_merge([], ...$arrays) quite a few times...