New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$exclude_disable is optional in get_defined_functions #3016

Closed
wants to merge 1 commit into
base: PHP-7.1
from

Conversation

4 participants
@carusogabriel
Contributor

carusogabriel commented Jan 10, 2018

Discovered it with PHPStan.

Documentation of get_defined_functions.

Edit: Should we add tests to cover it?

@carusogabriel carusogabriel changed the base branch from master to PHP-7.1 Jan 10, 2018

@nikic

This comment has been minimized.

Show comment
Hide comment
@nikic

nikic Jan 11, 2018

Member

Edit: Should we add tests to cover it?

Nope, arginfo changes don't need tests.

Member

nikic commented Jan 11, 2018

Edit: Should we add tests to cover it?

Nope, arginfo changes don't need tests.

@nikic nikic added the Bugfix label Jan 11, 2018

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Jan 11, 2018

Contributor

This issue has also been reported as https://bugs.php.net/75799.

Contributor

cmb69 commented Jan 11, 2018

This issue has also been reported as https://bugs.php.net/75799.

@php-pulls

This comment has been minimized.

Show comment
Hide comment
@php-pulls

php-pulls Jan 11, 2018

Comment on behalf of cmb at php.net:

Thanks for the PR! Applied in a843a86.

php-pulls commented Jan 11, 2018

Comment on behalf of cmb at php.net:

Thanks for the PR! Applied in a843a86.

@php-pulls php-pulls closed this Jan 11, 2018

@carusogabriel carusogabriel deleted the carusogabriel:fix-get-defined-functions branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment