Skip to content

$exclude_disable is optional in get_defined_functions #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

$exclude_disable is optional in get_defined_functions #3016

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Jan 10, 2018 •
edited
Loading

Discovered it with PHPStan.

Documentation of get_defined_functions.

Edit: Should we add tests to cover it?

@carusogabriel carusogabriel changed the base branch from master to PHP-7.1 January 10, 2018 21:50
@nikic
Copy link
Member

nikic commented Jan 11, 2018

Edit: Should we add tests to cover it?

Nope, arginfo changes don't need tests.

@nikic nikic added the Bug label Jan 11, 2018
@cmb69
Copy link
Member

cmb69 commented Jan 11, 2018

This issue has also been reported as https://bugs.php.net/75799.

@php-pulls
Copy link

Comment on behalf of cmb at php.net:

Thanks for the PR! Applied in a843a86.

@php-pulls php-pulls closed this Jan 11, 2018
@carusogabriel carusogabriel deleted the fix-get-defined-functions branch January 11, 2018 13:00
@carusogabriel carusogabriel mentioned this pull request Jan 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carusogabriel @nikic @cmb69 @php-pulls