Missing arginfo arginfo_pdostatement_setfetchmode

[carusogabriel]

Another found with PHPStan:

Method PDOStatement::setFetchMode() invoked with 3 parameters, 1-2 required.

By the docs, this method has variadics arguments, so how should we call it?

[nikic]

Unfortunately, this is a BC breaking change: https://3v4l.org/KgHR3 Given that these types of changes pretty much always seems to break one library or another, I'm going to close this.

Maybe the LSP rules could be changed to allow these changes in the future though...

[carusogabriel]

@nikic Thanks for the feedback.

Btw, LSP is the Liskov Substitution Principle?

[nikic]

@carusogabriel Yes. In particular I'm referring to our signature checks during inheritance. I think the current handling of parameters additions/removals is not ideal (though it's a somewhat tricky situation, especially considering the differences in handling of additional arguments for internal and user functions).