Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 75958: Remove true return when isn't helpful #3162

Closed
wants to merge 1 commit into from

Conversation

3 participants
@carusogabriel
Copy link
Member

commented Feb 27, 2018

As described in #75958, some Spl* methods have an always return true, which isn't helpful if it can't have a return false somehow.

@carusogabriel carusogabriel force-pushed the carusogabriel:return-true-spl branch from 2394c11 to d1ec06e Feb 27, 2018

@krakjoe

This comment has been minimized.

Copy link
Member

commented Feb 28, 2018

You can't do this, it breaks bc.

This hasn't been thought through :)

@krakjoe krakjoe closed this Feb 28, 2018

@nikic

This comment has been minimized.

Copy link
Member

commented Feb 28, 2018

Obviously we can't change this in 7.1, but this might be appropriate for master, given how unlikely it is that anyone relies on this? Alternatively, it might be good to have a list somewhere of minor BC breaking changes like this that we should make in 8.0.

@carusogabriel carusogabriel deleted the carusogabriel:return-true-spl branch Feb 28, 2018

@carusogabriel

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2018

@krakjoe Sorry forgot that changing function return type is a BC 😞

But, always return true functions isn't healthy for our code, right? bool, okay, but always true? 🤔

As @nikic, maybe something for master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.