Skip to content

Fix 75958: Remove true return when isn't helpful #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix 75958: Remove true return when isn't helpful #3162

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

As described in #75958, some Spl* methods have an always return true, which isn't helpful if it can't have a return false somehow.

@krakjoe
Copy link
Member

krakjoe commented Feb 28, 2018

You can't do this, it breaks bc.

This hasn't been thought through :)

@krakjoe krakjoe closed this Feb 28, 2018
@nikic
Copy link
Member

nikic commented Feb 28, 2018

Obviously we can't change this in 7.1, but this might be appropriate for master, given how unlikely it is that anyone relies on this? Alternatively, it might be good to have a list somewhere of minor BC breaking changes like this that we should make in 8.0.

@carusogabriel carusogabriel deleted the return-true-spl branch February 28, 2018 19:02
@carusogabriel
Copy link
Contributor Author

@krakjoe Sorry forgot that changing function return type is a BC 😞

But, always return true functions isn't healthy for our code, right? bool, okay, but always true? 🤔

As @nikic, maybe something for master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants