Lock fpm scoreboard while reading status #3185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scoreboard structs are locked so concise readings can be acquired. Fixes https://bugs.php.net/bug.php?id=76109
bukka
reviewed
Mar 18, 2018
| @@ -92,6 +97,9 @@ int fpm_status_handle_request(void) /* {{{ */ | |||
| return 1; | |||
| } | |||
|
|
|||
| struct fpm_scoreboard_proc_s procs[scoreboard_p->nprocs]; | |||
There was a problem hiding this comment.
I'm not sure if this is gonna work on all supported compilers. We also target C89 so definitions has to be at the beginning of block.
There was a problem hiding this comment.
Considering that VLA is C99, you can't really use it though.
|
@tback I think that memory allocation is a small overhead and this (status) is definitely not a perf critical path so I wouldn't worry about that. As I mentioned, you can't use VLA so there is not much options anyway... :) The It will go to 7.1 so if you could target it, that would be great! Thanks for your work! |
|
Thanks @bukka. I will close this PR and open another one when I have something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scoreboard structs are locked so concise readings can be acquired.
@bukka: I decided against implementing
fpm_scoreboard_copyfor now. The way I did it avoids explicit memory management because the scoreboard copies are put on the stack.I don't know exactly what php version introduced the fpm status page, but I know the code was present in 5.5 already.
Fixes https://bugs.php.net/bug.php?id=76109