Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdo_dblib closes connection when cursor closes #319

Closed
wants to merge 2 commits into from
Closed

pdo_dblib closes connection when cursor closes #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c51e328
NEW for #64565
remicollet Apr 2, 2013
e9cbf67
there's no need to close the connection when closing the cursor. See …
capile Apr 2, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ PHP NEWS
- Core:
. Fixed bug #64433 (follow_location parameter of context is ignored for most
response codes). (Sergey Akbarov)
. Fixed bug #64565 (copy doesn't report failure on partial copy). (Remi)

?? ??? 2013, PHP 5.4.14
- Core:
Expand Down
6 changes: 0 additions & 6 deletions ext/pdo_dblib/dblib_stmt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@ static char *pdo_dblib_get_field_name(int type)

static int dblib_dblib_stmt_cursor_closer(pdo_stmt_t *stmt TSRMLS_DC)
{
pdo_dblib_stmt *S = (pdo_dblib_stmt*)stmt->driver_data;
pdo_dblib_db_handle *H = S->H;

/* Cancel any pending results */
dbcancel(H->link);

efree(stmt->columns);
stmt->columns = NULL;

Expand Down