Remove warnings from inet_pton()/inet_ntop() #3200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveRandom
force-pushed
the
remove-inet-errors
branch
from
788bd90 to
2f4d7fd
Compare
|
Couldn't this be an issue for apps that convert warnings to exceptions and might relay on exception to be thrown? The fact that it's not documented doesn't mean that it can't break anything... :) We have got bunch of stuff not documented... +1 for master though... |
|
@bukka reluctantly agreed, will re-target master and merge |
DaveRandom
force-pushed
the
remove-inet-errors
branch
from
2f4d7fd to
ae90c7a
Compare
DaveRandom
force-pushed
the
remove-inet-errors
branch
from
ae90c7a to
822b47c
Compare
DaveRandom
force-pushed
the
remove-inet-errors
branch
from
822b47c to
658a23a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the warnings emitted by
inet_ntop()/inet_pton()as they do not impart any useful information not already available to userland, and superfluous warnings can cause debugging problems. These functions are frequently used as a quick mechanism to validate data from external sources along with normalization and conversion, so it is reasonable to expect that bad input may be supplied and this should not be considered exceptional.This patch targets 7.1, as the fact that these functions emit warnings is not documented and the warnings do not affect the required userland logic - the return value still needs to be checked for failures.Updated to target master.