Fixed bug #76136 (stream_socket_get_name enclosed IPv6 in brackets)

[seliver]

The IPv6 IP of a socket is provided by the inet_ntop as a string,
but this function doesn't enclose the ip in brackets. This patch
adds them in the php_network_populate_name_from_sockaddr function.

[seliver]

I tried adding the pull request to the bug tracking system, but unfortunately it didn't work.

[carusogabriel]

@seliver This was already reported at #76079. I'll look into that tonight 👍

[carusogabriel]

Missing ?>.

Also, please use EXPECT, is simpler than EXPECTF 👍

[seliver]

Done.

[seliver]

Is there something else that needs to be done on my side?

[nikic]

@seliver The Travis build is failing with:

========DIFF========
001+ Warning: stream_socket_server(): unable to connect to tcp://[::1]:1337/ (Cannot assign requested address) in /home/travis/build/php/php-src/tests/output/bug76136.php on line 2
002+ 
003+ Warning: stream_socket_get_name() expects parameter 1 to be resource, boolean given in /home/travis/build/php/php-src/tests/output/bug76136.php on line 3
004+ 
001- [::1]:1337
========DONE========
FAIL Bug #76136: stream_socket_get_name should enclose IPv6 in brackets [tests/output/bug76136.phpt] 

I assume that means that IPv6 is not supported? This probably needs a SKIPIF check.

Otherwise the change looks reasonable to me, but I'm not sure about BC impact etc. @bwoebi Can you check this? Which branch should it land on?

[nikic]

Ping @bwoebi @kelunik on BC impact. Can we do this and if so for 7.1 or 7.3 only?

[kelunik]

7.3 only, because not every workaround might account for the bug being fixed. We and ReactPHP do, but others might not.

[nikic]

Okay, let's go for PHP 7.3 then. @seliver, can you please update the test to skip if ipv6 is not supported? This will need a SKIPIF section with a check like this: https://github.com/php/php-src/blob/master/sapi/fpm/tests/tester.inc#L253

[nikic]

Merged as 9501304 with test adjustment.