At error_cb, set status header before send header

[robberphex]

Fix https://bugs.php.net/bug.php?id=50921

[nikic]

Looks reasonable to me, there are some tests that need to be adjusted though.

The bug report also mentions IE displaying a custom error page on ISE. Is this something it still does or have newer versions fixed that?

[robberphex]

All test passed. (and sapi/cli/tests/php_cli_server_015.phpt is modified)

---

For IE user/developer, they can go to Internet Options -> Advanced, and uncheck show friendly HTTP error messages, to see page with 500 code.

[nikic]

@weltling What do you think about this change?

[weltling]

@nikic I finally came to check it with various browsers. IE 11, the latest one, shows the same behavior with pretty error messages, which was kinda expected. Otherwise, besides FF and Chromium, even Edge shows the error message as is with 500 status.

The change seems to make sense as it aligns the returned HTTP status for more low level errors like undefined functions and syntax errors. Though, i'd be reluctant on rushing with it after reading the comments from Derick and Ferenc in the ticket. On the one hand, ofc it's logic and there are some more advantages - fe. misconfigured servers returting 500 are unlikely to be indexed by search engines. On the other hand - there can be non obvious side effects with existing apps and server configurations, having less to do with the actual browser issue but impacting the general operation.

With IE itself - for sure it's going to be supported for a while and some dedicated apps out there do exist. Still, the issue almost only development relevant. Neither a properly configured server should show these errors, nor the regular IE users would normally want to see them. The usage of the dev server fe seems to be fine as is, as it shows all the errors on stderr.

My suggestion would be to discuss on internals and go through RFC targeting PHP 7.4. For 7.3 it seems a bit too short cut, as for me, otherwise one should talk to the 7.3 RMs. At least Xdebug will need to catch up, other modules might be affected, too. The change itself is not big, but has a potential to affect beyond areas. OFC it'd need UPGRADING notes and possibly some documentation patch. Also perhaps more tests with display_errors=on/off and some fatal/syntax/etc. errors would not harm.

Thanks.

[robberphex]

Is there anything I can do? (subscribe mail list? write an RFC?)

[cmb69]

@robberphex See https://wiki.php.net/rfc/howto. And sorry for the late reply, but there's still time to walk through the RFC process for PHP 7.4.

[cmb69]

I'm closing this PR due to inactivity. @robberphex, feel free to fix the merge conflicts, and re-open.

Thanks for your work, anyway! :)