Skip to content

Conversation

coladict
Copy link
Contributor

Some headers are in a different location in Ubuntu, so the build normally fails.

@coladict coladict changed the base branch from master to PHP-7.2 June 27, 2018 11:40
@cmb69
Copy link
Member

cmb69 commented Jun 27, 2018

Any particular reason why this targets PHP-7.2, and not PHP-7.1 or master?

@remicollet
Copy link
Member

IMHO, when available, we should rely on pkg-config output

@coladict
Copy link
Contributor Author

I wrote it for 7.2.7 and have not checked for compatibility with 7.1. As for pkg-config, if we trust it, then it still prints /usr/include, which won't work for the check, but the /usr/include/x86_64-linux-gnu directory is still part of the global includes on the platform. The configure script will fail, even though the build can succeed.

@remicollet
Copy link
Member

which won't work for the check

when using pkg-config output, you DON'T have to check if the file exists, simply rely on its output (see other ext. which already use it)

@php-pulls
Copy link

Comment on behalf of petk at php.net:

Updating labels

@nikic
Copy link
Member

nikic commented Jan 11, 2019

I have implemented the pkg-config migration of ext/gd in #3739, which should resolve this issue in the most general way.

@nikic nikic closed this Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants