Skip to content

[RFC] Class Friendship #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[RFC] Class Friendship #3347

wants to merge 4 commits into from

Conversation

mdwheele
Copy link

@nikic nikic added the RFC label Jun 27, 2018
@cmb69
Copy link
Member

cmb69 commented Jul 7, 2018

@mdwheele Could you please resolve the failing tests? It seems to me that there are issues regarding the order of the class definitions, and also regarding the attempt to access private members of the class declaring the friendship.

@mdwheele @nikic The RFC says that it targets PHP 7.4 or PHP 8.0. If we postpone beta1 (which is quite likely, presently), the RFC could target PHP 7.3 in my opinion.

@mdwheele
Copy link
Author

mdwheele commented Jul 9, 2018

@cmb69 I can resolve issues with tests. In fact, the tests need to be updated. I'll will make time to do this before vote closes on Friday (even though, I am pretty sure it's a firm "No" at this point).

@php-pulls
Copy link

Comment on behalf of cmb at php.net:

Since the RFC has been declined, I'm closing this PR.

@php-pulls php-pulls closed this Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdwheele @cmb69 @php-pulls @nikic