Skip to content

Conversation

petk
Copy link
Member

@petk petk commented Jun 30, 2018

Hello, the rest of the core extensions don't display the extension versions in the phpinfo output since they in most cases match the PHP release version.

The rest of the core extensions don't display the extension versions in
the phpinfo output since they in most cases match the PHP release version.
@cmb69
Copy link
Member

cmb69 commented Jun 30, 2018

Considering the huge amount of PRs you've already made, I suggest that you apply for a PHP account and request php-src karma.

@petk
Copy link
Member Author

petk commented Jul 1, 2018

Sure, sounds great. I'll do that also.

@carusogabriel
Copy link
Contributor

@cmb69 Should I as well? 😄

@cmb69
Copy link
Member

cmb69 commented Jul 2, 2018

@carusogabriel Sure, go ahead! :)

@php-pulls
Copy link

Comment on behalf of cmb at php.net:

Thanks! Applied via 2900009.

@php-pulls php-pulls closed this Jul 3, 2018
@petk petk deleted the patch-phpinfo-xmlrpc branch July 3, 2018 15:33
@KalleZ
Copy link
Member

KalleZ commented Jul 3, 2018

@petk & @carusogabriel both of you can fill out the form at http://php.net/git-php you can mention that both me and @cmb69 have endorsed this.

For future patches after your accounts are approved you can always make a PR on Github if in doubt or consult with internals first which is the primary method of communication for the project.

@carusogabriel
Copy link
Contributor

@KalleZ @cmb69 Done, request sent 😊

@petk
Copy link
Member Author

petk commented Jul 4, 2018

I've send request also. Thanks to @cmb69 and @KalleZ for this suggestion and opportunity. Yes, I'll be using pull requests when things aren't clear enough or as is practice so far.

@carusogabriel you've done great commits so far, 👍 I like it...

@cmb69
Copy link
Member

cmb69 commented Jul 12, 2018

@carusogabriel @petk It seems your requests did not have been forwarded to the internals@ mailing list. Actually, the latest “VCS Account Request” I can find there is from 2016-05-24. Your accounts have been created, though, so I suggest that you write to internals@ to request php-src.git karma (at least).

PS: I've filed a respective bug report.

@carusogabriel
Copy link
Contributor

carusogabriel commented Jul 12, 2018

@cmb69 Should we send manually to internals@, then? :)

I've noticed that the email was created (https://people.php.net/carusogabriel), but I didn't received any email confirmation or something related.

@KalleZ
Copy link
Member

KalleZ commented Jul 12, 2018

@cmb69 I'm in the process of getting them granted karma, so no worries there

@nikic
Copy link
Member

nikic commented Jul 13, 2018

@petk @carusogabriel You now have karma for php-src and phpdoc. For php-src you will need to add an SSH key on master.git.php first. Some information on our git workflow is available at https://wiki.php.net/vcs/gitworkflow and https://wiki.php.net/vcs/gitfaq.

Welcome to the team!

@carusogabriel
Copy link
Contributor

Thank you all @KalleZ @cmb69 @nikic ❤️

@petk
Copy link
Member Author

petk commented Jul 13, 2018

Thanks @cmb69 @KalleZ @nikic It works indeed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants