-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove sqlite and xmlrpc extension versions from phpinfo output #3355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The rest of the core extensions don't display the extension versions in the phpinfo output since they in most cases match the PHP release version.
Considering the huge amount of PRs you've already made, I suggest that you apply for a PHP account and request php-src karma. |
Sure, sounds great. I'll do that also. |
@carusogabriel Sure, go ahead! :) |
Comment on behalf of cmb at php.net: Thanks! Applied via 2900009. |
@petk & @carusogabriel both of you can fill out the form at http://php.net/git-php you can mention that both me and @cmb69 have endorsed this. For future patches after your accounts are approved you can always make a PR on Github if in doubt or consult with internals first which is the primary method of communication for the project. |
I've send request also. Thanks to @cmb69 and @KalleZ for this suggestion and opportunity. Yes, I'll be using pull requests when things aren't clear enough or as is practice so far. @carusogabriel you've done great commits so far, 👍 I like it... |
@carusogabriel @petk It seems your requests did not have been forwarded to the internals@ mailing list. Actually, the latest “VCS Account Request” I can find there is from 2016-05-24. Your accounts have been created, though, so I suggest that you write to internals@ to request php-src.git karma (at least). PS: I've filed a respective bug report. |
@cmb69 Should we send manually to I've noticed that the email was created (https://people.php.net/carusogabriel), but I didn't received any email confirmation or something related. |
@cmb69 I'm in the process of getting them granted karma, so no worries there |
@petk @carusogabriel You now have karma for php-src and phpdoc. For php-src you will need to add an SSH key on master.git.php first. Some information on our git workflow is available at https://wiki.php.net/vcs/gitworkflow and https://wiki.php.net/vcs/gitfaq. Welcome to the team! |
Hello, the rest of the core extensions don't display the extension versions in the phpinfo output since they in most cases match the PHP release version.