Skip to content

Fixed bug #62596 add getallheaders in FPM #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed bug #62596 add getallheaders in FPM #3363

wants to merge 1 commit into from

Conversation

remicollet
Copy link
Member

  • add getallheaders (apache_request_headers) missing function in FPM
  • add sapi_add_request_header in public API (was add_request_header)
  • fix arginfo for fastcgi_finish_request fucntion

At leaset tracked as bug 62596

@remicollet
Copy link
Member Author

remicollet commented Jul 4, 2018 •
edited
Loading

@bukka please review

@cmb69 Despiste this is a small self-contain change, I really like to see this in 7.3 before beta1

@remicollet remicollet mentioned this pull request Jul 4, 2018
Closed
@remicollet
Fixed bug #62596 add getallheaders (apache_request_headers) missing f…
d201b34 
…unction in FPM

add sapi_add_request_header in public API (was add_request_header)
fix arginfo for fastcgi_finish_request fucntion
@remicollet remicollet force-pushed the issue-getallheaders branch from a652572 to d201b34 Compare July 4, 2018 07:04
@remicollet remicollet changed the title add getallheaders in FPM Fixed bug #62596 add getallheaders in FPM Jul 4, 2018
@AnnoyingTechnology
Copy link

Yessss ! Thank you, finally this gets fixed 👍

@cmb69
Copy link
Member

cmb69 commented Jul 4, 2018

@remicollet 7.3.0alpha3 has been tagged and built; I'd rather not go through the process again, unless absolutely necessary.

@remicollet
Copy link
Member Author

7.3.0alpha3 has been tagged and built; I'd rather not go through the process again, unless absolutely necessary.

@cmb69, I mean: I really like to see this in 7.3 "IN" beta1 (so applied in master "before" ...) ;)

@cmb69
Copy link
Member

cmb69 commented Jul 4, 2018

@remicollet Ah, I see. Then just make sure that the PR will be merged before 2018-07-17. :)

@bukka
Copy link
Member

bukka commented Jul 4, 2018

@remicollet I won't have much time to test it in the next few weeks but the test seems to pass and code looks good too so feel free to merge it to master now. Definitely good for the next alpha IMO!

@bukka
Copy link
Member

bukka commented Jul 4, 2018

Sorry I mean for the beta1 ofc :)

@remicollet
Copy link
Member Author

Merged

@remicollet remicollet closed this Jul 5, 2018
@remicollet remicollet deleted the issue-getallheaders branch July 5, 2018 04:46
@bukka bukka mentioned this pull request Jul 7, 2018
Closed
@bukka
Copy link
Member

bukka commented Jul 7, 2018

Added a small follow up in #3373

@khs1994
Copy link

khs1994 commented Oct 20, 2018

Should we update manual

http://php.net/manual/en/function.getallheaders.php

move getallheaders from apache to network

https://secure.php.net/manual/en/book.network.php

@khs1994 khs1994 mentioned this pull request Oct 20, 2018
Closed
@VaughnKearns
Copy link

Any Chance this will get fixed for PHP 7, 7.1 and 7.2?

salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Nov 9, 2018
@cmb69
Document that getallheaders() is now available under FPM
4ca676c 
Cf. <php/php-src#3363>.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345968 c90b9560-bf6c-de11-be94-00142212c4b1
svn2github pushed a commit to svn2github/phpdoc_en that referenced this pull request Nov 9, 2018
Document that getallheaders() is now available under FPM
e6be8ca 
Cf. <php/php-src#3363>.

git-svn-id: http://svn.php.net/repository/phpdoc/en@345968 c90b9560-bf6c-de11-be94-00142212c4b1
heiglandreas pushed a commit to phpdoctest/en that referenced this pull request Feb 4, 2020
Document that getallheaders() is now available under FPM
28cbf50 
Cf. <php/php-src#3363>.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345968 c90b9560-bf6c-de11-be94-00142212c4b1
salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Sep 3, 2020
@cmb69
Document that getallheaders() is now available under FPM
77b60aa 
Cf. <php/php-src#3363>.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345968 c90b9560-bf6c-de11-be94-00142212c4b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@remicollet @AnnoyingTechnology @cmb69 @bukka @khs1994 @VaughnKearns