Skip to content

Conversation

adsr
Copy link
Contributor

@adsr adsr commented Jul 11, 2018

All credit to @DaveRandom for original patch.

Overlaps with the following PRs I'm working on:

#2672
derickr/timelib#16

@adsr
Copy link
Contributor Author

adsr commented Aug 4, 2018

Bump for review @krakjoe @derickr

Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmb69
Copy link
Member

cmb69 commented Sep 13, 2018

@derickr Since this is a bugfix, shouldn't it be applied to PHP-7.1+?

@derickr
Copy link
Member

derickr commented Oct 8, 2018

@cmb69 — Of course it should.

@php-pulls
Copy link

Comment on behalf of cmb at php.net:

Thanks! Applied via c097acd.

@php-pulls php-pulls closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants