Fix bug #76030 RE2C_FLAGS rarely honoured #3430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PHP 5.3 the default lexer generator is RE2C. On Unix-alike build systems there is also optional configure option --enable-re2c-cgoto which enables optimized conditional jumps using non-standard computed goto extension. It is available since RE2C 0.10.3 so it's well covered by RE2C versions PHP uses. This patch syncs usage of -g option accross the PHP Unix-alike build system.
|
Comment on behalf of petk at php.net: Applied via e0fe667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 5.3 the default lexer generator is RE2C. On Unix-alike build systems there is also optional configure option
--enable-re2c-cgotowhich enables optimized conditional jumps using non-standard computed goto extension. It is available since R2C 0.10.3 so it's well covered by RE2C versions PHP uses. This patch syncs usage of-goption across the PHP Unix-alike build system.Patch is added thanks to @crrodriguez reported at #76030.
Since the generated files are added in the Git repository and also shipped with PHP releases, maybe it's still useful for the PHP 7.3 branch...
Note, that other syncs for the RE2C flags will be done in a separate patch for the master branch.
Thanks...