Skip to content

Fix #76403: MacOS compilation incorrectly linking to system libs #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix #76403: MacOS compilation incorrectly linking to system libs #3472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2297dd
Fix #76403: MacOS compilation incorrectly linking to system libs
javian Aug 27, 2018
46edde2
Support for additional variations such as XCode-beta.app
javian Sep 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions acinclude.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,11 @@ dnl
dnl Adds a path to linkpath/runpath (LDFLAGS)
dnl
AC_DEFUN([PHP_ADD_LIBPATH],[
if test "$1" != "/usr/$PHP_LIBDIR" && test "$1" != "/usr/lib"; then
case "$1" in
"/usr/$PHP_LIBDIR"|"/usr/lib"[)] ;;
/Library/Developer/CommandLineTools/SDKs/*/usr/lib[)] ;;
/Applications/Xcode*.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/*/usr/lib[)] ;;
*[)]
PHP_EXPAND_PATH($1, ai_p)
ifelse([$2],,[
_PHP_ADD_LIBPATH_GLOBAL([$ai_p])
Expand All @@ -452,8 +456,8 @@ AC_DEFUN([PHP_ADD_LIBPATH],[
else
_PHP_ADD_LIBPATH_GLOBAL([$ai_p])
fi
])
fi
]) ;;
esac
])

dnl
Expand Down