Implement #67331: Have parse_ini_file add empty entries #3473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some INI processors allow to specify empty values by just giving the key without the equals sign, for instance MySQL and Python. It appears to be sensible to add this possibility to our INI parser, so that it can be used for such INI files as well. We choose NULL as the value of empty values. This syntactical enhancement is a (minor) BC break, though, as can be seen by the necessary change to bug49692.ini. The “comment” formerly has been simply ignored, but now it would be parsed as key with an empty value. This PR is based on Adam's former patch.
|
If there are no objections, I'll merge this (plus respective notes in NEWS, UPGRADING and the manual) on the next weekend (i.e. in roughly a week). |
|
Comment on behalf of cmb at php.net: Applied via 3f3e914. Documented via http://svn.php.net/viewvc?view=revision&revision=345642. |
|
I have reverted the commit, since it broke some Windows tests (should have checked the Appveyor test failures more closely), and generally needs more though. I'll see if I can come up with a working implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some INI processors allow to specify empty values by just giving the
key without the equals sign, for instance MySQL and Python. It appears
to be sensible to add this possibility to our INI parser, so that it
can be used for such INI files as well. We choose NULL as the value of
empty values.
This syntactical enhancement is a (minor) BC break, though, as can be
seen by the necessary change to bug49692.ini. The “comment” formerly
has been simply ignored, but now it would be parsed as key with an
empty value.
This PR is based on Adam's former patch.