New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #76770: Unix time parsed as non relative. #3514

Open
wants to merge 3 commits into
base: master
from

Conversation

3 participants
@sam002
Copy link

sam002 commented Sep 10, 2018

Original bug:

'U' modifier in 'datetime::createFromFormat' adds seconds to other specifiers

Examples: https://3v4l.org/ZBN3W
Patch will corrected relative seconds in time struct.
Additional:

> re2c -v
re2c 0.16
@petk

This comment has been minimized.

Copy link
Member

petk commented Sep 10, 2018

Hello, thank you for the patch... Maybe worth noting that the ext/date/lib folder is actually a separate repository maintained at https://github.com/derickr/timelib and after release is done there, the folder here is updated also.

cc @derickr

@sam002

This comment has been minimized.

Copy link

sam002 commented Sep 11, 2018

@petk, thank you for explanatins.
I maked PR: derickr/timelib#47
But, what about tests?

@php-pulls

This comment has been minimized.

Copy link

php-pulls commented Oct 8, 2018

Comment on behalf of petk at php.net:

Labelling

@php-pulls php-pulls added the Bugfix label Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment