Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #76770: Unix time parsed as non relative. #3514

Closed
wants to merge 6 commits into from

Conversation

@sam002
Copy link
Contributor

@sam002 sam002 commented Sep 10, 2018

Original bug:

'U' modifier in 'datetime::createFromFormat' adds seconds to other specifiers

Examples: https://3v4l.org/ZBN3W
Patch will corrected relative seconds in time struct.
Additional:

> re2c -v
re2c 0.16
@petk
Copy link
Member

@petk petk commented Sep 10, 2018

Hello, thank you for the patch... Maybe worth noting that the ext/date/lib folder is actually a separate repository maintained at https://github.com/derickr/timelib and after release is done there, the folder here is updated also.

cc @derickr

@sam002
Copy link
Contributor Author

@sam002 sam002 commented Sep 11, 2018

@petk, thank you for explanatins.
I maked PR: derickr/timelib#47
But, what about tests?

@php-pulls
Copy link

@php-pulls php-pulls commented Oct 8, 2018

Comment on behalf of petk at php.net:

Labelling

@krakjoe
Copy link
Member

@krakjoe krakjoe commented Jan 30, 2019

@sam002 the only thing that needs to be in this pr is the test, we don't accept timelib changes in this repo.

@sam002
Copy link
Contributor Author

@sam002 sam002 commented Aug 31, 2019

@krakjoe Sorry for delay. Cleared changes in ext libs.

@krakjoe
Copy link
Member

@krakjoe krakjoe commented Oct 3, 2019

@derickr can you take a look at this one please ?

@sam002
Copy link
Contributor Author

@sam002 sam002 commented Nov 8, 2020

@derickr @krakjoe Up. PR was merged in timelib: derickr/timelib@396dbfc
This PR ready for merge.
Build for updated (merged with current master) branch is success completed: https://travis-ci.org/github/sam002/php-src/builds/742194429

@sam002
Copy link
Contributor Author

@sam002 sam002 commented Nov 8, 2020

@petk FYI see prev.

@cmb69
cmb69 approved these changes Dec 23, 2020
Copy link
Contributor

@cmb69 cmb69 left a comment

Thank you!

@php-pulls php-pulls closed this in 959d3c9 Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants