Add bless_tests.php script #3529
Conversation
This can be used for mass-updates of tests. After running run-tests.php, call bless_tests.php on the relevant directory to automatically update the expected test outputs. Afterwards review the diff to check that the new output is indeed correct. This is particularly useful for dealing with annoying variation tests, where every little change has to be replicated dozens of times.
|
This is a very basic implementation that I've been using, e.g. for the test updates in #3526. The intention is to land this and extend it with additional replacements and checks as they become necessary. |
| ); | ||
| foreach ($it as $file) { | ||
| $path = $file->getPathName(); | ||
| if (!preg_match('/^(.*)\.phpt$/', $path, $matches)) { |
There was a problem hiding this comment.
Can't we simplify this call to a
-preg_match('/^(.*)\.phpt$/', $path, $matches)
+substr($path, -5) === '.phpt'? The usage of preg_match is confused something IMHO :)
| file_put_contents($path, $phpt); | ||
| } | ||
|
|
||
| function normalizeOutput(string $out): string { |
There was a problem hiding this comment.
Maybe we can expand this function to receive something from the command line. This script would help me a lot in #3429
There was a problem hiding this comment.
Not sure I understand what you mean here. Could you give an example?
There was a problem hiding this comment.
The function current has hard-coded to only fix "Resource id". I wonder if we can have some way to provide what is gonna to be changed, as #3429. Just an idea, nothing that blocks its merge as it is.
|
Comment on behalf of petk at php.net: Labelling |
|
Merged as 7a17be7. Getting regular use out of this one... |
This can be used for mass-updates of tests. After running
run-tests.php, call bless_tests.php on the relevant directory to
automatically update the expected test outputs. Afterwards review
the diff to check that the new output is indeed correct.
This is particularly useful for dealing with annoying variation
tests, where every little change has to be replicated dozens of
times.