Require SQLite ≥ 3.5.0 #3543
Closed
Require SQLite ≥ 3.5.0 #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pdo_sqlite has the same issue. Should tackle this as well. |
|
I'll wait on the outcome of PR #3548, before pursuing this further. |
It is possible to pass flags when opening an SQLite database. For Sqlite < 3.5.0 these are ignored, since `sqlite3_open` doesn't support flags. Neither a warning or notice is raised in this case, nor is this behavior documented in the PHP manual. Instead of fixing it either way, we lift the requirement to SQLite 3.5.0 (released on 2007-09-04) instead of the former SQLite 3.3.9 (released on 2007-01-04).
|
Rebased and overhauled to cater to pdo_sqlite as well. |
nikic
reviewed
Oct 6, 2018
This has been introduced by a bad rebase conflict resolution.
|
Closing and re-opening to trigger CI, which failed for unrelated reasons. |
|
Hmm, this time AppVeyor failed for unrelated reasons, but Travis succeeded. Anyhow, if there are no objections, I'll merge this PR on the next weekend. |
|
Comment on behalf of petk at php.net: Labelling |
|
Comment on behalf of cmb at php.net: Applied via 87392ef. |
|
Documented via http://svn.php.net/viewvc?view=revision&revision=345812. |
salathe
pushed a commit
to salathe/phpdoc-en
that referenced
this pull request
Oct 13, 2018
Cf. <php/php-src#3543>. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345812 c90b9560-bf6c-de11-be94-00142212c4b1
svn2github
pushed a commit
to svn2github/phpdoc_en
that referenced
this pull request
Oct 14, 2018
Cf. <php/php-src#3543>. git-svn-id: http://svn.php.net/repository/phpdoc/en@345812 c90b9560-bf6c-de11-be94-00142212c4b1
heiglandreas
pushed a commit
to phpdoctest/en
that referenced
this pull request
Feb 4, 2020
Cf. <php/php-src#3543>. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345812 c90b9560-bf6c-de11-be94-00142212c4b1
salathe
pushed a commit
to salathe/phpdoc-en
that referenced
this pull request
Sep 3, 2020
Cf. <php/php-src#3543>. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@345812 c90b9560-bf6c-de11-be94-00142212c4b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to pass flags when opening an SQLite database. For
Sqlite < 3.5.0 these are ignored, since
sqlite3_opendoesn't supportflags. Neither a warning or notice is raised in this case, nor is this
behavior documented in the PHP manual. Instead of fixing it either
way, we lift the requirement to SQLite 3.5.0 (released on 2007-09-04)
instead of the former SQLite 3.3.9 (released on 2007-01-04).