mb_str_split() added #3713
Closed
mb_str_split() added #3713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This function should be part of the mbstring extension (to be found in ext/mbstring), rather than inside the standard extension. Furthermore it will need support for arbitrary encodings (those supported by mbstring/libmbfl), rather than only UTF-8. |
petk
reviewed
Dec 23, 2018
ok. Moved to mbstring.c as another pull request #3715 |
|
This is my first commit. It would be good if you tell me what is good and what is bad. Thank you. |
|
Thanks for the new pull request. Should this one be closed then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mb_str_split() added