Fixed bug #77326 (ReflectionClass::getReflectionConstant() returns false instead of exception)

[heyanlong]

For details please refer to bug report 77326

[carusogabriel]

Adding an exception is a BC IMHO 👎

[krakjoe]

CI is failing ... and I'm not convinced you have justified the broken compatibility, plenty of other reflection API methods do return false on failure, and that's what is expected ...

[KalleZ]

I think it should be everything or nothing. This for sure can't go into anything but PHP 7.4 at earliest.

Instead of changing them one by one, it should either all be throwing exceptions or returning false. In my fair opinion in regards to this specific one, I think returning false is perfectly suitable.

[petk]

Since this is opened, wouldn't be exceptions way to go into the future for PHP next versions? For example, when using strict types (way where all programming goes more or less sooner or later), usually one might expect that certain function returns certain value. And if the returned value type is array like in this particular case, returning false from some method is what is unexpected actually. And wrapping core functions is then the only way to be completely sure that certain function returns certain type. Returning false is even difficult to describe in the php documentation itself - mixed or with current types state ?array. I might be wrong though and there is some better practice.

[heyanlong]

Sorry, if it is not bug, please close this request

[KalleZ]

@petk it would be for sure be the way to go for the future. I just think that we might as well do it for everything at the same go, instead of doing it gradually

[KalleZ]

@heyanlong the report is perfectly valid, but like I said, we should consider doing it for all the methods instead of just doing them one by one