Fix feof hanging on TLS streams (bug #77390) #3729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2018
|
@bukka Maybe you want to review. |
|
This seems to be addressed by #3223, right? I would prefer that one as it also has got a test. It just needs a bit more testing, checking and possibly a little changes in the test to integrate proxy to the existing server-client class. I will try to find some time in the next few weeks. Should have much more time in a week or two hopefully! |
|
That's basically the same patch, yes, totally forgot about that one. |
annda
added a commit
to annda/dokuwiki
that referenced
this pull request
Apr 14, 2021
feof() sometimes hangs if nothing has beeen written yet see php/php-src#3729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.php.net/bug.php?id=77390.
If
n == 0onSSL_ERROR_SYSCALL, the stream is broken, e.g. because the remote hung up. Removed the infinite loop in case ofSSL_ERROR_WANT_{READ,WRITE}in case the remote doesn't send any more data. As theSSL_ERROR_SYSCALLshows if the socket is closed, it's alive in case ofSSL_ERROR_WANT_{READ,WRITE}.