Welcome 2019

[carusogabriel]

No description provided.

[php-pulls]

Comment on behalf of carusogabriel at php.net:

Labelling

[petk]

Happy New Year... 🎉 Is there any script maybe behind this so it could be run on certain extensions repos and similar files with such headers?

[petk]

Some more files:

• Zend/header
• Zend/zend_dtrace.c
• Zend/zend_dtrace.d
• Zend/zend_dtrace.h

[carusogabriel]

Is there any script maybe behind this so it could be run on certain extensions repos and similar files with such headers?

@petk Not that I know :(

[petk]

• scripts/man1/php-config.1.in
• scripts/man1/phpize.1.in
• sapi/cli/php.1.in
• sapi/fpm/php-fpm.8
• sapi/phpdbg/phpdbg.1.in

[petk]

I'm not sure about these (maybe these should be removed from Git tracking but anyway):

• win32/php7dllts.rc2
• win32/php7ts_cli.rc2
• win32/php7ts.rc2

[carusogabriel]

@petk Thanks, I'll update this patch with your suggestions!

[petek]

@carusogabriel I’m still not @petk

[carusogabriel]

@petk Just the win32/build/template.rc file I could change without affecting the encoding. Looks like VIM changes it while saving.

[petk]

@carusogabriel I think with Vim it should work ok and it shouldn't change encodings. You can check file encoding with:

file win32/build/template.rc

or run this from the terminal:

sed -i 's/1997-2018/1997-2019/g' win32/build/template.rc

[carusogabriel]

@petk Using Atom and Vim I could edit this file without affecting the encoding. Feel free to merge this one if everything is okay and edit the missing file!

[petk]

This should be done the same also for PHP-7.2, and PHP 7.3? PHP-7.1 also?

[petk]

I think this is best to be added by a release manager that has access to PHP 7.1 branch which is in the security patches mode only. Is there any option to reproduce this patch for those branches also?

[carusogabriel]

@petk I did it by searching and replacing all the occurrences. Maybe we can automate a script to do these changes every year.

[petk]

Would be good and also not so complicated I think... In PHP or shell?

P.S: Last year I think such patch targeted also all other active branches via separate pull requests for easier applying...

[jhdxr]

I suggest we consider using some like present to replace the year. (actually this a topic we will repeat every year. e.g. ccd4716 .

No offence but I don't see much value to keep repeating this work.

[carusogabriel]

@jhdxr We can raise this topic, I've seen this present solution in a couple of places as well.

[petk]

Technically speaking, the end year in these license/copyrights ranges don't change the license itself or grant anything special to license holders since it should be automatically granted and extended with the initial year added. It is done more for a contextual understanding and seeing that particular software has been "refreshed" than anything legal :) Otherwise, the initial year is all that matters and is automatically extended to a license holder(s)... When new license holders are added the new year range is started and so on.

The copyright with present year range will look a bit strange in man pages because I'm not sure anyone uses such approach in those man pages.

Otherwise I also use only -present in some MIT licenses, for example. Yes, it's a very neat trick for sure - for a bit smaller projects that are in phase of development or something.

Some projects go even further, and define each year separately 1997, 1998, 1999...

Should the code files maybe start using a more simplified version of the header without year ranges? That way, only in few files the year range should be updated.

P.S: Symfony's year range has been reverted otherwise and they don't use -present anymore.

[petk]

Question: this is something that might be good to go?

/*
  +----------------------------------------------------------------------+
  | PHP Version 7                                                        |
  +----------------------------------------------------------------------+
  | Copyright (c) The PHP Group                                          |
  +----------------------------------------------------------------------+
  | This source file is subject to version 3.01 of the PHP license,      |
  | that is bundled with this package in the file LICENSE, and is        |
  | available through the world-wide-web at the following url:           |
  | https://php.net/license/3_01.txt                                     |
  | If you did not receive a copy of the PHP license and are unable to   |
  | obtain it through the world-wide-web, please send a note to          |
  | license@php.net so we can mail you a copy immediately.               |
  +----------------------------------------------------------------------+
  | Authors:                                                             |
  +----------------------------------------------------------------------+
*/

[KalleZ]

I think this topic should be raised on internals@

[nikic]

🎉 38c337f 🎉