pdo_oci: Add PDO_OCI_ATTR_ACTION and PDO_OCI_ATTR_CLIENT_INFO #3762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to set the action and client info on the database session for PDO OCI using PDO attributes.
|
@cjbj for your consideration, thanks :) |
|
@camporter can I convince you to add OCI_ATTR_CLIENT_IDENTIFIER and OCI_ATTR_MODULE too? |
cjbj
requested changes
Jan 25, 2019
|
Definitely! I'll add the other two. |
Add tests for the new attributes, and check the setAttribute return value.
|
Running tests on PHP-7.2.14: |
|
Comment on behalf of sixd at php.net: Merged Oracle DB end-to-end tracing attributes |
|
@camporter thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set the action and client info on the database session for PDO OCI using PDO attributes.
This makes PDO OCI equivalent to oci8 extension functionality of having
oci_set_actionandoci_set_client_infofunctions.Please let me know if there happens to be a better way to go about adding the ability to set these values.