list interfaces/adding just "binary" state status. #3766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalleZ
approved these changes
Jan 28, 2019
|
@sgolemon As you added this function, any comments? |
nikic
reviewed
Feb 12, 2019
| status = zend_hash_str_find(Z_ARR_P(iface), "up", sizeof("up") - 1); | ||
| if (!status) { | ||
| add_assoc_bool_ex(iface, "up", sizeof("up") - 1, ((p->ifa_flags & IFF_UP) != 0)); | ||
| } |
There was a problem hiding this comment.
Just doing the add_assoc_bool_ex without the lookup beforehand should be fine here. Can also use add_assoc_bool and save the sizeof("up") - 1 argument.
There was a problem hiding this comment.
Was not sure about the "importance" of this new entry so I put in the end :-)
devnexen
force-pushed
the
network_interface_status
branch
from
e0f0c60 to
808a6e5
Compare
|
Probably won t have any feedback as it is a tiny addition :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.