Fix #77530: PHP crashes when parsing "(2)::class" #3768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks right to me. I've assigned to Nikita, because I'm not sure if anywhere else makes the same sort of assumption that might need to be fixed ? |
|
Merged as ef68cd3 into 7.2+. From a cursory look I didn't see other cases where this is an issue. Most code-paths use compile_class_ref. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR hopes to fix bug: https://bugs.php.net/bug.php?id=77530
Class name was assumed to be a string. The PR checks whether it is a string before type fetch, and throws a fatal error in case it is not.