-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[WIP] Remove deprecated functionality in PHP 8 #3770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks Nikita, I was gonna do this once I saw your branching emails. I guess it would make sense to also add the 7.3 deprecations to this PR: Perhaps we should also finalize and move forward our combined RFC for 7.4? |
e2a5294
to
35824c5
Compare
35824c5
to
c7d7af8
Compare
Oops, I messed something up here. |
98cb832
to
ca6d9c5
Compare
1b332bb
to
0dfd918
Compare
This is close to done. Apart from some tricky constant related things, these two items are left:
I don't want to change code that I can't build / test, so maybe @heiglandreas and @KalleZ would like to take care of those? We still have various deprecations for things like mbstring / iconv internal_encoding handling around since PHP 5 times, but I believe the last time I tried to remove those I ran into implementation bugs, that made them non-equivalent to the new alternatives. |
The |
971fbc1
to
f743900
Compare
I'm removing the argument entirely here, but we might want to change this to passing null or and empty array instead, if the impact of dropping it entirely is too large. This was deprecated as part of https://wiki.php.net/rfc/deprecations_php_7_2 as a doc-only deprecation.
f743900
to
8b8934f
Compare
This is done now from my side. Remaining is the odbc one, as well as the long-standing iconv/mbstring encoding deprecations. |
@nikic I removed the |
Work in progress removal of deprecated functionality.
From https://wiki.php.net/rfc/deprecations_php_7_2:
From https://wiki.php.net/rfc/deprecations_php_7_3:
From https://wiki.php.net/rfc/remove_php4_constructors:
From https://wiki.php.net/rfc/case_insensitive_constant_deprecation:
From https://wiki.php.net/rfc/deprecate_mb_ereg_replace_eval_option:
From https://externals.io/message/85595:
From https://externals.io/message/86849:
From https://wiki.php.net/rfc/deprecate-bareword-strings:
From https://wiki.php.net/rfc/reclassify_e_strict (and followup):
From ba28d75: