Skip to content

Test the 'Unknown encoding' warning of the mb_strwith function #3777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Test the 'Unknown encoding' warning of the mb_strwith function #3777

wants to merge 2 commits into from

Conversation

coudenysj
Copy link
Contributor

@nikic
Copy link
Member

nikic commented Jan 31, 2019

It would be good to add this to an existing mb_strwidth test, to reduce CI time.

@coudenysj
Copy link
Contributor Author

Ok, so I've created #3778 to cover all mb_str* functions in one phpt test file.

@nikic
Copy link
Member

nikic commented Feb 11, 2019

Closing in favor of #3778 then, as that seems like a much better approach.

@nikic nikic closed this Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Tests Waiting on Author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coudenysj @nikic @krakjoe