Skip to content

zend_weakrefs #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

zend_weakrefs #3787

wants to merge 1 commit into from

Conversation

krakjoe
Copy link
Member

@krakjoe krakjoe commented Feb 2, 2019 •
edited
Loading

For weakrefs RFC, fresh pull

@krakjoe krakjoe added the RFC label Feb 2, 2019
carusogabriel
carusogabriel reviewed Feb 3, 2019
View reviewed changes
petk
petk reviewed Feb 3, 2019
View reviewed changes
petk
petk reviewed Feb 3, 2019
View reviewed changes
petk
petk reviewed Feb 3, 2019
View reviewed changes
nikic
nikic reviewed Feb 4, 2019
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Still) looking good. Just some minor comments.

@krakjoe
Copy link
Member Author

krakjoe commented Mar 11, 2019

Amended implementation #3934

@krakjoe krakjoe closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

@petk petk petk left review comments

+1 more reviewer

@carusogabriel carusogabriel carusogabriel left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krakjoe @nikic @petk @carusogabriel