[PHP TestFest]: PR 1

[petk]

Patch for pull request phpcommunity/phptestfest-php-src#1

Discussion: https://externals.io/message/104224

[nikic]

We shouldn't merge XFAIL tests. But this can serve as motivation for someone to actually fix the issue, as it looks pretty simple :)

[carusogabriel]

@petk Also, I'll be review those PRs to see if there's something that we can close already or isn't necessary and maybe we can propose a single PR with all tests

[petk]

@carusogabriel do I start opening PRs based on the approved tests from you? For me, one of the more important things is also the commit from the original author (where it can be done)... For the tests, where they should be changed completely, or aren't ok, I'll recheck what's the best option to go. Maybe pinging the authors on the pull requests first, and then PRs here...

@nikic thanks for the info. Let me see what I can do with this...

[carusogabriel]

@petk IMO we can merge right away the trivial tests with mine and Joe’s approvals, no need to reopen a PR here. We can discuss and modify them in the PHPTest repo and should be ready to go.

[petk]

@carusogabriel temporary helper method: https://docs.google.com/spreadsheets/d/1So8jKG5YGBKsmCAqqa1LHfNOlFipb0--0IQTNveHMWY/edit?usp=sharing
(green == approved, violet == merged)