Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for libreadline #3823

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@remicollet
Copy link
Contributor

commented Feb 13, 2019

libreadline is GPL, so incompatible with PHP

  • remove --with-libedit option and rely on pkg-config instead
  • remove --with-readline DIR option
  • cleanup conditions using HAVELIBREADLINE or HAVE_LIBEDIT
  • keep HAVE_LIBEDIT in php_config.h is some extension use it

Notice: Windows already only support libedit

@remicollet

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

Notice: if merged, I plan to add a deprecation warning in 7.4

@nikic

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Looks like you'll have to install libedit on Travis.

I'm personally fine with making this change. Supporting two different libraries with subtly different behavior and different feature set is not a good idea. If libedit is available everywhere, I don't see a disadvantage to normalizing on it.

@remicollet remicollet force-pushed the remicollet:issue-nolibreadline branch 2 times, most recently from c64922b to 256d4c4 Feb 13, 2019

@remicollet

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

readline_list_history also added for 7.x in pr #3824

@petk petk added the Enhancement label Feb 16, 2019

@remicollet remicollet force-pushed the remicollet:issue-nolibreadline branch from 256d4c4 to 3dff2c0 Feb 22, 2019

Drop support for libreadline
libreadline is GPL, so incompatible with PHP

@remicollet remicollet force-pushed the remicollet:issue-nolibreadline branch from 3dff2c0 to 5256d35 Feb 22, 2019

@remicollet

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Rebased and travis is happy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.