Make ABI of SIMD optimized functions independent of compiler flags #3828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged as 96daef0. |
| @@ -575,14 +576,15 @@ static zend_always_inline double _zend_get_nan(void) /* {{{ */ | |||
| # define ZEND_INTRIN_SSSE3_FUNC_DECL(func) | |||
| #endif | |||
|
|
|||
| #if defined(HAVE_SSE4_2_DEF) || (defined(ZEND_WIN32) && defined(__SSE4_2__)) | |||
| #if __SSE4_2__ | |||
There was a problem hiding this comment.
#ifdef __SSE4_2__
was this line before #3826 (but not sure if important)
There was a problem hiding this comment.
Thanks for the pointer, I'll change this. It makes no difference here, but better to stay consistent with the other checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #3826 for PHP 7.4.