-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add installed php extensions to temporary created ini file #3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The mentioned build failure seems not to be related to this patch - how to proceed ? |
@rhabacker Please, rebase with |
You can just ignore the failure. A change to the Linux build system is definitely not going to break the Windows build ;) |
I love this change, working around this problem myself right now with the tideways extension, where tests depend on a lot of other extensions to verify instrumentation works. |
Anyone there who can merge this pull request ? |
So, this is happening when the mbstring is built as shared extension, right? Yes, the shared extensions have many quirks... /o\ This seems to work ok, except one minor thing, I think. When the path to the extension is set as absolute path in the original *.ini file (/etc/php/conf.d/mbstring.ini) file, for example, Yes, as for the regex part of |
You suggest to remove the extension related part |
In php extensions configured with phpize, a temporarily generated php.ini is used for testing, but currently contains no installed PHP extensions, which is required by the mailparse extension, for example. Installed extensions must be added with their absolute path, because the extension_dir parameter is already occupied. See https://bugs.php.net/bug.php?id=77609&edit=2
Applied via 3ead672 to PHP-7.2+ with few slight adjustments... Thank you @rhabacker for the patch. |
This patch has been reverted, see 3ead672#commitcomment-32840691, so the issue is still present. |
In php extensions configured with phpize, a temporarily generated
php.ini is used for testing, but currently contains no installed
PHP extensions, which is required by the mailparse extension,
for example.
Installed extensions must be added with their absolute path,
because the extension_dir parameter is already occupied.
See https://bugs.php.net/bug.php?id=77609&edit=2