Fix bug #73948: Trailing NULL padding for UNMATCHED_AS_NULL #3964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for https://bugs.php.net/bug.php?id=73948, targeting 7.4 for BC concerns.
There's two changes here affecting UNMATCHED_AS_NULL mode:
When using offset capture, instead of creating an array[null, -1]
, insert justnull
.I'm not so sure about the second bit. I think this is how this should work, but possibly we need to stick with the current behavior for BC.
/cc @cmb69