Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDO] Disable cloning of PDO handle/connection objects to avoid segfault #4011

Closed
wants to merge 3 commits into from

Conversation

@camporter
Copy link
Contributor

commented Apr 5, 2019

A simple fix for bug 77849. However, there may be connections that can clone without issue, in which case a clone handle would be needed and would need to be done selectively.

@krakjoe

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

The test can be much simpler: What we are testing is that clone will fail, we're not testing for a fault here because we know it cannot happen if we prohibit clone: Just do $db = PDOTest::factory(); and clone and test for the expected exception ...

@camporter

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

👍 I'd originally added the additional querying because I wanted to tell if there happened to be other drivers that did not segfault after cloning before this change. Went ahead and removed the querying now.

@krakjoe krakjoe self-assigned this Apr 5, 2019
@krakjoe

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Merged as 9ec1525

Thanks.

@krakjoe krakjoe closed this Apr 5, 2019
@krakjoe

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Followed up with a2b8a62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.