Fix #77011: configure cannot detect iconv library on Mojave (macOS 10.14) #4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ".tbd" extension support for libiconv on Mac to use CommandLineTools SDK shared library.
|
As iconv can't be detected using pkg-config, including something like this should be okay. |
|
@petk Any concerns here? |
|
Thank you @gabrielrcouto for the patch. I've applied this to PHP-7.4+ for now via e28db22. I'm not able to come up with a better fix for now... Because this now also means that on next macOS version PHP 7.2 and 7.3 won't be possible to build without 3rd party outside the php-src repo patches so we probably will still want to fine tune the patch proposed in the #3616... Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ".tbd" extension support for libiconv on Mac to use CommandLineTools SDK shared library.
I know library detection code is being ported and another PR solved the same problem, but this is a simple and temporary solution which enables Mac Mojave users to keep contributing with PHP on this mean time.
I tested this patch running:
./configure --enable-debug --enable-cli --with-iconv=$(xcrun --show-sdk-path)/usr