Simplify generated_lists generation #4025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated_lists file is generated as a helper for build related makefile to include a list of *.m4 files prerequisites. When some *.m4 file changes the configure script is regenerated when buildconf is run. This can be simplified using dynamic expansion in the Makefile directly so it avoids another file from being generated in the project root directory and shipping it with the PHP release or creating a dedicated gitignore rule.
nikic
reviewed
Apr 15, 2019
|
Seconded, I'm fine with GNU make. It's ubiquitous on UNIX and available on Windows (as |
|
Applied via b09fa9e to the PHP-7.4+. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
the
generated_listsfile is generated as a helper for build related makefile to include a list of *.m4 files prerequisites. When some *.m4 file changes the configure script is regenerated whenbuildconfis run. This can be simplified using dynamic expansion in the Makefile directly using the!=operator so it avoids another file from being generated in the project root directory and shipping it with the PHP release or creating a dedicated gitignore rule.Tested on Linux, mac, FreeBSD, Solaris...
Few more tests will be done, but this is pretty close to a finished PR.
Requires:
GNU Make 4.0+GNU Make 3.81+Redacted: Now this patch works in GNU Make 3.81+ (or even 3.6) and also everyone else's make.