Skip to content

Fix 77921: static.php.net doesn't work anymore #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petk
Copy link
Member

@petk petk commented Apr 18, 2019

This embeds the PHP logo image in the FPM status HTML page instead of using remote location.

This embeds the PHP logo image in the FPM status HTML page instead of
using remote location.
@petk petk added the Bug label Apr 18, 2019
@KalleZ KalleZ requested a review from bukka April 18, 2019 22:54
@petk
Copy link
Member Author

petk commented Apr 20, 2019

Applied via 4450288 to PHP-7.2+... The phpinfo() uses the same PNG image data and browser support is good enough for this:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs

Since the commit now also auto closed the bug report already, the README.md file patch for PHP-7.4+ is on its way in separate commit.

@petk petk closed this Apr 20, 2019
@petk petk deleted the patch-77921 branch April 20, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant