-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[aarch64] use crc32 instructions when available #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any reference about execution time benchmark?
I'm not sure what you are asking for, could you please be more specific? The benchmark is a synthetic one that I run with the timing code from Zend/bench.php. |
@sebpop, thank you for your reply. I want to know where the reference presents about this performance issue. |
Is there anything that needs to be addressed in this change, or is it ok to commit? |
I rebased the patch on master, and tested with |
The time goes from 0.838s down to 0.029s (a 28x speedup) on a Graviton A1 instance and the following benchmark: function simple_crc32() { $a = "foo"; for ($i = 0; $i < 10000; $i++) { crc32($a); $a .= "o".$i; } }
Merged as 2a535a9, thanks! |
The time goes from 0.175s down to 0.007s on a Graviton A1 instance on the
following benchmark: