Re-add common PDO tests to Firebird test suite #4112
Conversation
These have been inadvertently dropped when changing the test suite to not require ext/interbase anymore, so we add them back. We also change the required environment variable names to match the usual PDO names. Particularly, we replace `PDO_FIREBIRD_TEST_HOSTNAME` and `_DATABASE` with the more flexible `PDO_FIREBIRD_TEST_DSN`.
| define('PDO_FIREBIRD_TEST_PASSWORD', getenv('PDO_FIREBIRD_TEST_PASSWORD') ?: 'phpfi'); | ||
| define('PDO_FIREBIRD_TEST_HOSTNAME', getenv('PDO_FIREBIRD_TEST_HOSTNAME') ?: 'localhost'); | ||
| define('PDO_FIREBIRD_TEST_DATABASE', getenv('PDO_FIREBIRD_TEST_DATABASE') ?: ''); | ||
| define('PDO_FIREBIRD_TEST_USER', getenv('PDO_FIREBIRD_TEST_USER') ?: 'SYSDBA'); |
There was a problem hiding this comment.
How about using the following code snippets:
......
getenv('PDO_FIREBIRD_TEST_USER') ?? 'SYSDBA';
......It's the PHP 7 syntax.
There was a problem hiding this comment.
@peter279k we can’t as getenv() returns false, not null
There was a problem hiding this comment.
Ok, using the ?: syntax to detect condition if it is false.
| $dbh = new PDO(PDO_FIREBIRD_TEST_DSN, PDO_FIREBIRD_TEST_USER, PDO_FIREBIRD_TEST_PASS) or die; |
There was a problem hiding this comment.
If the DB connection is failed, I think we need to output some notification message via die function.
It can make use have note that the DB connection status message.
There was a problem hiding this comment.
PDO already yields an error message, die simply prevents further execution
There was a problem hiding this comment.
Ok. It's fine to use die function.
|
Ah I wasn't aware of this magic I removed with PDO, in that case lets go for it. I think its a more elegant solution with the DSN environment variable too |
These have been inadvertently dropped when changing the test suite to
not require ext/interbase anymore, so we add them back.
We also change the required environment variable names to match the
usual PDO names. Particularly, we replace
PDO_FIREBIRD_TEST_HOSTNAMEand
_DATABASEwith the more flexiblePDO_FIREBIRD_TEST_DSN.