New function: pcntl_daemonize & pcntl_setaffinity. #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,13 @@ | |||
| #include <sys/resource.h> | |||
| #endif | |||
|
|
|||
| #ifdef HAVE_SCHED_SETAFFINITY | |||
| #ifndef __USE_GNU | |||
There was a problem hiding this comment.
I've read __USE_GNU shouldn't be used directly: http://stackoverflow.com/questions/7296963/gnu-source-and-use-gnu
Is it right?
There was a problem hiding this comment.
Yes, if you want to use GNU extensions, you'd probably want to define _GNU_SOURCE before including the header (just as outlined in the man page of sched_setaffinity).
|
Note that both of your tests fail on Travis. |
|
For both functions I'd opt for a name more akin to the original names: pcntl_daemon() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcntl_daemonize: run as a daemon.
pcntl_setaffinity: set cpu binding.