Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug #77978 #4160

Open
wants to merge 1 commit into
base: PHP-7.2
from

Conversation

4 participants
@KonstantinKuklin
Copy link

commented May 14, 2019

Wrong relative path on unpacking zip archives with :/ character sequences

@petk petk added the Bugfix label May 14, 2019

@cmb69

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Hmm, simply removing the check for ':' is likely to break things on Windows (consider 'C:/foo').

@KonstantinKuklin

This comment has been minimized.

Copy link
Author

commented May 15, 2019

@cmb69 thank you for notification

@KonstantinKuklin KonstantinKuklin force-pushed the KonstantinKuklin:bug_77978 branch 8 times, most recently from 86c3850 to c073d66 May 15, 2019

@KonstantinKuklin

This comment has been minimized.

Copy link
Author

commented May 25, 2019

ready for review @cmb69

@KonstantinKuklin KonstantinKuklin force-pushed the KonstantinKuklin:bug_77978 branch from c073d66 to b17f99a May 25, 2019

@cmb69

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@KonstantinKuklin, please remove the changes to NEWS. This should be added by the person who merges the PR. Otherwise there will be merge conflicts al the time. :)

@remicollet , what do you think about the patch?

Fixed bug #77978
Wrong relative path on unpacking zip archives with ".","..",":" character sequences
on different platforms

@KonstantinKuklin KonstantinKuklin force-pushed the KonstantinKuklin:bug_77978 branch from b17f99a to 75fce83 Jun 6, 2019

@krakjoe

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

@remicollet bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.