Add get_mangled_object_vars() function

[nikic]

This function provides the same functionality as (array) $object, with the caveat that it is not affected by any overloaded (array) casts. In particular it will always provide the real object properties for ArrayObject and derived classes, even if the STD_PROP_LIST flag is not set.

[KalleZ]

I would prefer if this was named something like get_mangled_object_vars for consistency with get_class_vars and get_object_vars, not pretty sure, but consistent.

[nikic]

@KalleZ Agreed and done!

[guilliamxavier]

Thanks for your work, just: typo "mandled" in test filename (and commit messages also)

[Ocramius]

Just a test change required: could you please use var_export(), so that \0 in keys are visible?

[nikic]

@Ocramius Done!

[Majkl578]

Wouldn't this be better as part of ReflectionProperty instead? There is also no way to easily get a map of unmangled -> mangled or vice versa.

[nikic]

@Majkl578 This would have to be on ReflectionObject if anything. However there are some performance concerns. If we want people to replace existing (array) casts with this function, it needs to have comparable performance. The cases where this functionality is needed tend to use it a lot.

[Majkl578]

@nikic Likely both, what I meant was ReflectionProeprty::getMangledName().

[nikic]

@Majkl578 We could add getMangledName(). Any particular use you have in mind for it?

[KalleZ]

@staabm The correct phrasing of the word is mangled, see:
https://www.dictionary.com/browse/mangled

[nikic]

@staabm Apart from the suggestion being grammatically incorrect, was it really necessary to send the same suggested edit 9 times, each as a separate comment (not as part of a review), each sending out a new email? Please don't do that.

[staabm]

The correct phrasing of the word is mangled, see:

I just realized this. thx for the hint.

Apart from the suggestion being grammatically incorrect, was it really necessary to send the same suggested edit 9 times, each as a separate comment (not as part of a review), each sending out a new email? Please don't do that

very sorry about that. will be more carefully next time.
since the comments were wrong overall I deleted them again.

sorry for the noise.

[Majkl578]

@nikic:

We could add getMangledName(). Any particular use you have in mind for it?

Sure, just a few I remember right now:
https://github.com/doctrine/common/blob/v2.10.0/lib/Doctrine/Common/Proxy/ProxyGenerator.php#L631
https://github.com/doctrine/orm/blob/v2.6.3/lib/Doctrine/ORM/Mapping/Reflection/ReflectionPropertiesGetter.php#L156-L161
https://github.com/phpstan/phpstan/blob/0.11.8/src/Type/ObjectType.php#L342-L354
https://github.com/Ocramius/ProxyManager/blob/2.4.0/src/ProxyManager/ProxyGenerator/Util/Properties.php#L177-L181
https://github.com/Ocramius/ProxyManager/blob/2.4.0/src/ProxyManager/ProxyGenerator/Util/Properties.php#L199-L201

[nikic]

@Majkl578 Thanks! Sounds like a good addition then. Would you like to submit a PR? Otherwise I can do it.

[Majkl578]

Sure, could try that. :)

[nikic]

Merged as eecd896 into 7.4.