Skip to content

Fix #78114: segfault when calling sodium_* functions from eval #4230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #78114: segfault when calling sodium_* functions from eval #4230

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jun 6, 2019

We must not follow the NULL pointer.

@cmb69
Copy link
Member Author

cmb69 commented Jun 6, 2019

See also #3708 (comment).

@cmb69 cmb69 requested a review from nikic June 6, 2019 07:32
nikic
nikic approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ext/sodium/tests/bug78114.phpt
echo $ex->getMessage(), PHP_EOL;
}
?>
===DONE===
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop unnecessary ===DONE===.

@cmb69
Copy link
Member Author

cmb69 commented Jun 6, 2019

Thanks! Applied as 22a3fa0.

@cmb69 cmb69 closed this Jun 6, 2019
@cmb69 cmb69 deleted the fix-78114 branch June 6, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmb69 @nikic