Change ReflectionMethod object construction to support get_method-based methods #4271
Conversation
Support constructing a ReflectionMethod from an object that has a get_method handler that can be used to reflect methods that aren't in the class entry, such as PDO driver-specific methods.
camporter
force-pushed
the
use_get_method_for_reflectionmethod
branch
from
36d6902 to
9e7c5f5
Compare
|
@nikic, any chance to get this reviewed? This inconsistency causes issues during static analysis of the code that uses this API (e.g. phpstan/phpstan#3527). |
| // a get_method object handler exists, so try to get the method from it | ||
| zend_string *method_string = zend_string_init(lcname, name_len, 0); | ||
|
|
||
| mptr = obj_handlers->get_method(&Z_OBJ_P(classname), method_string, NULL); |
There was a problem hiding this comment.
Doesn't this throw for inaccessible methods?
There was a problem hiding this comment.
I haven't touched this in a while, zend_std_get_method would? What would be the best way to reconcile either letting get_method handle throwing an error or otherwise throwing the exception below?
I might be misunderstanding though 🙂
|
@camporter What's the status of this PR? |
|
I'm not sure this is feasible, or at least I'm not familiar with how to make it feasible. Can go ahead and close the PR. |
|
Thanks! |
Support constructing a
ReflectionMethodfrom an object that has aget_methodobject handler that can be used to reflect methods that aren't in the class entry, such as PDO driver-specific methods.Some downsides are that
ReflectionClass::getMethods()used with aPDOobject of a specific driver type still won't list the driver-specific methods. I'm also not sure this can be supported onReflectionClass::getMethod().This is just an experiment for trying to solve issues like reported in bug 78126.
Not using
get_methodto add driver specific methods (add them to the PDO class entry directly?) would be another way to solve the issue, but that's obviously a much larger change and has side effects.