Implement FR #77230: Support custom CFLAGS and LDFLAGS from environment #4353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is already possible to *set* CFLAGS and LDFLAGS (actually all variables) from the environment for `nmake` (by passing the `/E` option), it is not possible to *add* any (C|LD)FLAGS, which can be useful in some cases. Instead of allowing this for `nmake`, we add support for additional custom (C|LD)FLAGS to `configure`, similar to how that works on Linux, so one could actually write: ```` set CFLAGS=foo & set LDFLAGS=bar & configure ```` This also allows us to use these flags during configure.
KalleZ
approved these changes
Jul 2, 2019
|
LGTM |
|
If there are no objections, I'll merge this on 2019-07-08 (so it makes it into PHP 7.4.0alpha3). |
|
Applied as 338e1b2. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is already possible to set CFLAGS and LDFLAGS (actually all
variables) from the environment for
nmake(by passing the/Eoption), it is not possible to add any (C|LD)FLAGS, which can be
useful in some cases. Instead of allowing this for
nmake, we addsupport for additional custom (C|LD)FLAGS to
configure, similar tohow that works on Linux, so one could actually write:
This also allows us to use these flags during configure.