Skip to content

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jul 12, 2019

Splits #4254

Takes the rather straight forward conversion of php_error_docref0() to php_error_docref() and remove the define in php.h

@nikic
Copy link
Member

nikic commented Jul 12, 2019

@petk Any data on php_error_docref0 use in extensions?

@Girgias
Copy link
Member Author

Girgias commented Jul 12, 2019

Only two minor ones:

* https://github.com/datastax/php-driver/blob/587c83d68f665a5c32680e583ff3727626b8eff2/ext/src/Cluster/Builder.c#L133

* Swoole
  
  * https://github.com/swoole/swoole-src/blob/d33e429ccaeb508bc0818a9afeef1d0cc9df7b66/thirdparty/php/sockets/sendrecvmsg.cc#L34
  * https://github.com/swoole/swoole-src/blob/d33e429ccaeb508bc0818a9afeef1d0cc9df7b66/thirdparty/php/sockets/conversions.cc#L123

I'll make some PRs for those two extensions. Thanks for the info :)

Edit: Done.

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. In that case I think this is okay.

@php-pulls php-pulls closed this in 1c1de0c Jul 13, 2019
@Girgias Girgias deleted the convert-docref0 branch July 13, 2019 00:15
@remicollet
Copy link
Member

Notice that this change breaks ABI
(undefined symbol: php_error_docref0)

@petk
Copy link
Member

petk commented Jul 23, 2019

@remicollet -> #4470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants