Fix #65547: Default value for sunrise/sunset zenith still wrong

[cmb69]

The value of the zenith angle to calculate sunrise and sunset times is
commonly defined as 90°50', and is "obtained by adding the average
apparent radius of the Sun (16') to the average amount of atmospheric
refraction at the horizon (34')", according to
http://aa.usno.navy.mil/faq/docs/RST_defs.php.

This value is also used for the Sunrise/Sunset Algorithm published in
the Almanac for Computers, 1990, see
https://web.archive.org/web/20161202180207/http://williams.best.vwh.net/sunrise_sunset_algorithm.htm.

[cmb69]

This is a revival of PR #3088, this time targeting PHP 8. @derickr, should be okay now?

PS: date_sun_info() now also uses the corrected zenith.

[derickr]

Yeah, I'm OK for that. I would also suggest we have a look at these defaults too: https://github.com/php/php-src/pull/4412/files#diff-7b738accc3d60f74c259da18588ddc5dR581

[cmb69]

@derickr, ah yes; see also https://externals.io/message/26033. I don't think that any default is particularly reasonable – should these ini settings be removed?

PS: especially doubtful, since the ini settings are not used for date_sun_info(), but only for date_sunrise() and date_sunset().

[cmb69]

Applied as 7556600. Thanks!

[derickr]

Yes, they should be removed. I wrote date_sun_info() later, which really does more than the other two functions and I didn't feel like reimplementing that oddity again :-)